From 7ba7d3563c6cafefb9f646d617e70e0d7bbf037e Mon Sep 17 00:00:00 2001 From: imcompiling Date: Fri, 22 Dec 2023 21:33:34 -0500 Subject: [PATCH] Rework logic to use less loops. --- cogs/commands/view.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cogs/commands/view.py b/cogs/commands/view.py index 26b2c76..f4b87d3 100644 --- a/cogs/commands/view.py +++ b/cogs/commands/view.py @@ -54,16 +54,16 @@ class ViewCog(commands.Cog, name="View Commands"): stmt = select(Presences.Presence) presences = session.scalars(stmt) - message = "" - - # have 2 loops so that the "if search" check isn't done repeatedly if search: - for presence in presences: - if search.lower() in presence.lower(): - message += f"{presence}\n" + message = "\n".join( + [ + presence + for presence in presences + if search.lower() in presence.lower() + ] + ) else: - for presence in presences: - message += f"{presence}\n" + message = "\n".join(list(presences)) await interaction.followup.send(content=message, ephemeral=True)