imcompiling/dakiny-bot
1
0
Fork 0
Code Issues 22 Pull Requests 9 Actions Packages Projects Activity

bot providing incorrect election cycle due to new years. #47

New Issue
Closed
opened 2024-01-01 13:21:53 -05:00 by imcompiling · 1 comment
imcompiling commented 2024-01-01 13:21:53 -05:00
Owner
Copy Link
Copy Source

Multiple things cause this issue.

  • returning -1 when getting the election cycle did not work as intended. It would instead make the bot use the last item in the config election list rather than none. This is a python feature that I didn't think about. Force a crash using None for now. Maybe think of a more elegant solution later.
  • The first of the year is not within the correct election cycle for some reason. Need to make sure that it is, then the problem goes away.
Multiple things cause this issue. - returning -1 when getting the election cycle did not work as intended. It would instead make the bot use the last item in the config election list rather than none. This is a python feature that I didn't think about. Force a crash using None for now. Maybe think of a more elegant solution later. - The first of the year is not within the correct election cycle for some reason. Need to make sure that it is, then the problem goes away.
imcompiling added reference 47-incorrect-election-cycle 2024-01-01 13:23:37 -05:00
imcompiling commented 2024-01-01 13:52:36 -05:00
Author
Owner
Copy Link
Copy Source

Issue was that the beginning of the election cycle for the last quarter (December) was not being brought back to last year, so the current day was not less than the beginning of the election.

Issue was that the beginning of the election cycle for the last quarter (December) was not being brought back to last year, so the current day was not less than the beginning of the election.
Sign in to join this conversation.
47-incorrect-election-cycle
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate-bot imcompiling
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: imcompiling/dakiny-bot#47