imcompiling/dakiny-bot
1
0
Fork 0
Code Issues 22 Pull Requests 9 Actions Packages Projects Activity

view votes can't see HC elections #49

New Issue
Closed
opened 2024-01-09 09:05:16 -05:00 by imcompiling · 8 comments
imcompiling commented 2024-01-09 09:05:16 -05:00
Owner
Copy Link
Copy Source

When I am selecting election to view from, I am only looking at the election information for elections. This is incorrect now since I added the highcouncil elections. They are not added as a new election, rather just adding an affix to the current election name and adding votes to it.

Easiest solution will be to modify the statement for retrieving the election names to be all unique names within the Votes table.

When I am selecting election to view from, I am only looking at the election information for elections. This is incorrect now since I added the highcouncil elections. They are not added as a new election, rather just adding an affix to the current election name and adding votes to it. Easiest solution will be to modify the statement for retrieving the election names to be all unique names within the Votes table.
imcompiling added the bug label 2024-01-09 09:05:16 -05:00
imcompiling commented 2024-01-09 09:12:05 -05:00
Author
Owner
Copy Link
Copy Source

Alternative solution would be to modify the Votes table to track whether it is a HC vote outside of the election name. This would solve this issue but also that the foreign key in Votes doesn't exist for HC election names. This would require a bit more work (modifying the existing election information) but would be better design.

Alternative solution would be to modify the Votes table to track whether it is a HC vote outside of the election name. This would solve this issue but also that the foreign key in Votes doesn't exist for HC election names. This would require a bit more work (modifying the existing election information) but would be better design.
imcompiling added a new dependency 2024-01-09 20:02:35 -05:00
#48 Revamp view votes command
imcompiling commented 2024-01-09 20:03:39 -05:00
Author
Owner
Copy Link
Copy Source

Threw in the quick bandaid fix mentioned above in main.

The main action of this issue will be to design the Votes table better so that the HC votes are linked properly to each ElectionInformation entry.

Work will have to be done to convert the old data into the new table.

Threw in the quick bandaid fix mentioned above in main. The main action of this issue will be to design the Votes table better so that the HC votes are linked properly to each ElectionInformation entry. Work will have to be done to convert the old data into the new table.
imcompiling added reference 49--view-votes-can't-see-HC-elections 2024-05-18 15:39:22 -04:00
imcompiling commented 2024-05-18 15:40:52 -04:00
Author
Owner
Copy Link
Copy Source

Refitting the Votes table to have a field that determines the type of vote from [Council, DiscordManager, ClanLeader]. Still need to convert old data along with editing the high council voting actions.

Refitting the Votes table to have a field that determines the type of vote from [Council, DiscordManager, ClanLeader]. Still need to convert old data along with editing the high council voting actions.
imcompiling commented 2024-05-18 15:54:58 -04:00
Author
Owner
Copy Link
Copy Source

Also need to update the view command to be able to use the new type.

Also need to update the view command to be able to use the new type.
imcompiling commented 2024-05-18 16:32:09 -04:00
Author
Owner
Copy Link
Copy Source

I am using an enum within python to define the type. Python 3.11 introduced String Enums, so now I would like to upgrade python versions to 3.12.

I am using an enum within python to define the type. Python 3.11 introduced String Enums, so now I would like to upgrade python versions to 3.12.
imcompiling commented 2024-05-18 16:32:40 -04:00
Author
Owner
Copy Link
Copy Source

After upgrading, need to edit the database to add back the check for Type, and change the variable type.

After upgrading, need to edit the database to add back the check for Type, and change the variable type.
imcompiling added a new dependency 2024-05-18 16:33:46 -04:00
#61 Create virtual environment and update python version.
imcompiling changed reference from 49--view-votes-can't-see-HC-elections to 49-view-votes-can't-see-HC-elections 2024-05-18 23:14:02 -04:00
imcompiling changed reference from 49-view-votes-can't-see-HC-elections to 49-view-votes-cant-see-HC-elections 2024-05-18 23:15:15 -04:00
imcompiling commented 2024-05-18 23:34:00 -04:00
Author
Owner
Copy Link
Copy Source

Updated all database definitions to current. Just need to edit the data (election name and vote types) once done with the development.

Updated all database definitions to current. Just need to edit the data (election name and vote types) once done with the development.
imcompiling commented 2024-05-19 11:37:35 -04:00
Author
Owner
Copy Link
Copy Source

It worked first try surprisingly.

Updated all data on dakiny server.

It worked first try surprisingly. Updated all data on dakiny server.
Sign in to join this conversation.
49-view-votes-cant-see-HC-elections
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate-bot imcompiling
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#48 Revamp view votes command
imcompiling/dakiny-bot
Depends on
#61 Create virtual environment and update python version.
imcompiling/dakiny-bot
Reference: imcompiling/dakiny-bot#49